Codecov Report

Merging #92 (c6b71ae) into master (b794f7b) will decrease coverage by 0.07%.
The diff coverage is 16.33%.

@@             Coverage Diff              @@
##             master      #92      +/-   ##
============================================
- Coverage     20.39%   20.31%   -0.08%     
- Complexity      111      133      +22     
============================================
  Files            63       71       +8     
  Lines          2859     3012     +153     
  Branches        381      402      +21     
============================================
+ Hits            583      612      +29     
- Misses         2261     2379     +118     
- Partials         15       21       +6     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b794f7b...c6b71ae. Read the comment docs.

I used toSNBT instead of toString to be explicit that it's converting to stringifies NBT/mojangson, rather than a JSON string or something else. I can change if people thing it would be better

I used toSNBT instead of toString to be explicit that it's converting to stringifies NBT/mojangson, rather than a JSON string or something else. I can change if people thing it would be better

I wonder if something like toNBTString() would be a better name, should be the best of both worlds?

Sure! we good for StringNBT then?

NbtBooleanTag is correct for Google's Java Style Guide which we will be looking to implement, so should we go with that instead of NBTBooleanTag?

src: https://google.github.io/styleguide/javaguide.html#s5.2.2-class-names (UpperCamelCase class naming)

Merging on hold until after module refactor.

CodeQL

• Inconsistent equals and hashCode (NbtNumberTag.java)
  https://github.com/DumbDogDiner/StickyAPI/security/code-scanning/67?query=ref%3Arefs%2Fheads%2Ffeat%2Fstring-nbt-helpers
• Overloaded equals (NbtBooleanTagTest.java)
  https://github.com/DumbDogDiner/StickyAPI/security/code-scanning/61?query=ref%3Arefs%2Fheads%2Ffeat%2Fstring-nbt-helpers
• Inconsistent equals and hashCode (NbtStringTag.java)
  https://github.com/DumbDogDiner/StickyAPI/security/code-scanning/60?query=ref%3Arefs%2Fheads%2Ffeat%2Fstring-nbt-helpers
• Inconsistent equals and hashCode (NbtJsonTag.java)
  https://github.com/DumbDogDiner/StickyAPI/security/code-scanning/59?query=ref%3Arefs%2Fheads%2Ffeat%2Fstring-nbt-helpers
• Inconsistent equals and hashCode (NbtBooleanTag.java)
  https://github.com/DumbDogDiner/StickyAPI/security/code-scanning/58?query=ref%3Arefs%2Fheads%2Ffeat%2Fstring-nbt-helpers